objchange: fix ProposedNew from null objects#29701
Merged
Conversation
The codepath for AllAttributesNull was not correct for any nested object types with collections, and should create single null values for the correct NestingMode rather than a single object with null attributes. Since there is no reason to descend into nested object types to create nullv alues, we can drop the AllAttributesNull function altogether and create null values as needed during ProposedNew. The corresponding AllBlockAttributesNull was only called internally in 1 location, and simply delegated to schema.EmptyValue. We can reduce the package surface area by dropping that function too and calling EmptyValue directly.
jbardin
added
the
1.0-backport
jbardin
force-pushed
the
jbardin/proposed-new-null-objs
branch
from
18d3542 to
8271765
Compare
alisdair
reviewed
Oct 5, 2021
Contributor
alisdair
left a comment
alisdair
left a comment
There was a problem hiding this comment.
This looks correct to me, but I don't understand the test failures in CI 🤔
Member
Author
|
Ah, data sources plan using an unknown prior value, which is not tested at all in the objchange package. I'll add another test for that too. |
jbardin
force-pushed
the
jbardin/proposed-new-null-objs
branch
from
8271765 to
58d85fc
Compare
alisdair
approved these changes
Oct 5, 2021
ghost
mentioned this pull request
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The codepath for
AllAttributesNullwas not correct for any nested objecttypes with collections, and should create single null values for the
correct NestingMode rather than a single object with null attributes.
Since there is no reason to descend into nested object types to create
null values, we can drop the
AllAttributesNullfunction altogether andcreate null values as needed during
ProposedNew.The corresponding
AllBlockAttributesNullwas only called internally in 1location, and simply delegated to
schema.EmptyValue. We can reduce thepackage surface area by dropping that function too and calling
EmptyValuedirectly.Fixes #29697