Conversation
ghost
force-pushed
the
backport/alisdair/init-lock-flags/oddly-healthy-hare
branch
from
32824a6 to
24ba744
Compare
alisdair
deleted the
backport/alisdair/init-lock-flags/oddly-healthy-hare
branch
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #29773 to be assessed for backporting due to the inclusion of the label 1.0-backport.
The below text is copied from the body of the original PR.
The
-lockand-lock-timeoutflags were removed in #27464 prior to the release of 1.0 as they were thought to have no effect. This is not true in the case of state migrations when changing backends. This commit restores these flags, and adds test coverage for locking during backend state migration.Documentation does not need to be updated, as it currently shows that the flags are present. I intend to backport this change to 1.0 because I believe this removal was a bug.
Fixes #29765.