getproviders: account for occasionally missing Host header in errors#31542
Merged
radeksimko merged 1 commit intomainfrom Jul 29, 2022
Merged
getproviders: account for occasionally missing Host header in errors#31542radeksimko merged 1 commit intomainfrom
Host header in errors#31542radeksimko merged 1 commit intomainfrom
Conversation
Host header in errors
Contributor
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR to #30810 and #29298
They each aimed to add more context to the following error messages:
Based on some recent CI runs, it became clear that
Request.Hostmay sometimes be empty, which results in the following error message:See https://github.com/hashicorp/terraform-ls/runs/7574713438?check_suite_focus=true#step:6:46
I don't actually know under what exact circumstances would the
Hostbe missing. It is clear however from reading the implementation ofnet/http.Request.Write()that this may happen.I therefore propose to mimic what the stdlib does here, to ensure we always expose the host in the error message.
I expect #31524 can be updated to take advantage of this too, once this PR is merged.