Skip to content

Backport of filter computed attrs from ignore_changes=all into v1.3#31885

Merged
jbardin merged 2 commits intov1.3from
backport/jbardin/ignore-changes-all-computed/centrally-factual-colt
Sep 28, 2022
Merged

Backport of filter computed attrs from ignore_changes=all into v1.3#31885
jbardin merged 2 commits intov1.3from
backport/jbardin/ignore-changes-all-computed/centrally-factual-colt

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Sep 28, 2022

Backport

This PR is auto-generated from #31747 to be assessed for backporting due to the inclusion of the label 1.3-backport.

The below text is copied from the body of the original PR.


When handling ignore_changes=all, we must filter computed attributes
from the prior state to prevent them showing in the configuration. Since
it's not valid for the user to have set computed attributes in the
config, the provider should expect to never see any values there. The
oversight has only now become apparent, as more providers adopt the
plugin-framework which has direct access to the plan-time configuration
value.

@ghost ghost requested a review from jbardin September 28, 2022 13:28
@ghost ghost force-pushed the backport/jbardin/ignore-changes-all-computed/centrally-factual-colt branch from 0208319 to 40e85cd Compare September 28, 2022 13:28
@jbardin jbardin merged commit 48a999f into v1.3 Sep 28, 2022
@jbardin jbardin deleted the backport/jbardin/ignore-changes-all-computed/centrally-factual-colt branch September 28, 2022 13:40
@github-actions
Copy link
Copy Markdown
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link
Copy Markdown
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant