Fix no-op outputs causing the plan renderer to skip the 'no changes' message#32820
Fix no-op outputs causing the plan renderer to skip the 'no changes' message#32820liamcervante merged 2 commits intomainfrom
Conversation
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
So, I'm unclear... |
|
Note for history, the above question was answered in #32815 (comment) |
…message (hashicorp#32820) * Fix no-op outputs causing the plan renderer to skip the 'no changes' message * fix imports
…message (hashicorp#32820) * Fix no-op outputs causing the plan renderer to skip the 'no changes' message * fix imports
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Currently, we are checking whether the output changes are empty before deciding to print the "no changes" message in the renderer. But, no-op changes do not print anything so any plan with no-op changes will make the renderer consider the output changes to be not empty so it won't print the nice message but then it also won't print any outputs.
This PR fixes this by computing the concrete output diffs earlier and then using them to decide whether to print the "no changes" message.
Fixes #32815
Target Release
1.4.1
Draft CHANGELOG entry
BUG FIXES