Skip to content

Backport of Fix rendering unknown values in map and null string primitives into v1.4#33033

Merged
liamcervante merged 3 commits intov1.4from
backport/liamcervante/33016/endlessly-huge-bunny
Apr 14, 2023
Merged

Backport of Fix rendering unknown values in map and null string primitives into v1.4#33033
liamcervante merged 3 commits intov1.4from
backport/liamcervante/33016/endlessly-huge-bunny

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Apr 14, 2023

Backport

This PR is auto-generated from #33029 to be assessed for backporting due to the inclusion of the label 1.4-backport.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

The below text is copied from the body of the original PR.


This PR fixes 2 issues in the new renderer:

  1. Unknown values are removed from the set of after values by the json plan package for attributes. This affects maps as they are unaware of the values they are supposed to contain. This PR makes the renderer look at the planned unknown values and merge them back into the main after set before computing the diff.
  2. Null strings were being rendered with the %q format which meant they were being encapsulated by quotation marks and the color encodings were being rendered as a string.

This PR fixes both of these issues.

Fixes #33016

Target Release

1.4.6

Draft CHANGELOG entry

BUG FIXES

  • Fix bug when rendering plans that include null strings
  • Fix bug when rendering plans that include unknown values in maps

@ghost ghost force-pushed the backport/liamcervante/33016/endlessly-huge-bunny branch 2 times, most recently from 2f8c66b to 2837da5 Compare April 14, 2023 07:56
@ghost ghost requested a review from liamcervante April 14, 2023 07:56
@ghost ghost force-pushed the backport/liamcervante/33016/endlessly-huge-bunny branch from 9a40546 to 5f0c5c0 Compare April 14, 2023 07:56
@liamcervante liamcervante merged commit 3ea88aa into v1.4 Apr 14, 2023
@liamcervante liamcervante deleted the backport/liamcervante/33016/endlessly-huge-bunny branch April 14, 2023 08:09
@github-actions
Copy link
Copy Markdown
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link
Copy Markdown
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant