Backport of Fix rendering unknown values in map and null string primitives into v1.4#33033
Merged
liamcervante merged 3 commits intov1.4from Apr 14, 2023
Merged
Conversation
2f8c66b to
2837da5
Compare
9a40546 to
5f0c5c0
Compare
liamcervante
approved these changes
Apr 14, 2023
Contributor
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #33029 to be assessed for backporting due to the inclusion of the label 1.4-backport.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
This PR fixes 2 issues in the new renderer:
%qformat which meant they were being encapsulated by quotation marks and the color encodings were being rendered as a string.This PR fixes both of these issues.
Fixes #33016
Target Release
1.4.6
Draft CHANGELOG entry
BUG FIXES