Backport of Refactor of differ to make code reuse easier into v1.4#33066
Merged
liamcervante merged 2 commits intov1.4from Apr 21, 2023
Merged
Conversation
added 2 commits
April 20, 2023 08:50
ghost
force-pushed
the
backport/liamcervante/sensitive_and_unknown/one/evidently-mature-dodo
branch
from
3d37624 to
36d7a22
Compare
ghost
force-pushed
the
backport/liamcervante/sensitive_and_unknown/one/evidently-mature-dodo
branch
from
d55d43e to
76029d6
Compare
liamcervante
approved these changes
Apr 21, 2023
Contributor
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
liamcervante
deleted the
backport/liamcervante/sensitive_and_unknown/one/evidently-mature-dodo
branch
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #33054 to be assessed for backporting due to the inclusion of the label 1.4-backport.
The below text is copied from the body of the original PR.
This PR is a required step before the change in #33057
Here we move the Change object into a separate and independent package such that the differ package and the jsondiff package can both access it. This will be required as in the linked PR we will start processing the unknown and sensitive metadata within the change in the jsondiff package, while before we were manually passing a subset of the data.