Skip to content

Backport of Propagate unknown and sensitive metadata to dynamic attributes into v1.4#33075

Merged
liamcervante merged 2 commits intov1.4from
backport/liamcervante/sensitive_and_unknown/two/routinely-prepared-goblin
Apr 24, 2023
Merged

Backport of Propagate unknown and sensitive metadata to dynamic attributes into v1.4#33075
liamcervante merged 2 commits intov1.4from
backport/liamcervante/sensitive_and_unknown/two/routinely-prepared-goblin

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Apr 24, 2023

Backport

This PR is auto-generated from #33057 to be assessed for backporting due to the inclusion of the label 1.4-backport.

The below text is copied from the body of the original PR.


This PR updates the jsonformat/jsondiff package to include and process the sensitive and computed metadata about the given change.

The package now handles Change objects directly, something that is only possible with the refactor in #33054. This is a good change because now it is actually processing all the information in the change instead of simple subset as it was previously.

The change also moves the logic for processing unknown and sensitive types into the shared structured package so that the differ and the jsondiff package can share the logic.

Fixes #33056

Target Release

1.4.6

Draft CHANGELOG entry

BUG FIXES

  • Fix bug where the sensitive and unknown metadata wasn't being propagated to dynamic attribute types when rendering.

@ghost ghost force-pushed the backport/liamcervante/sensitive_and_unknown/two/routinely-prepared-goblin branch from e296ec3 to 6cfb6df Compare April 24, 2023 08:28
@ghost ghost requested a review from liamcervante April 24, 2023 08:28
@ghost ghost force-pushed the backport/liamcervante/sensitive_and_unknown/two/routinely-prepared-goblin branch from 4380242 to 23d28f8 Compare April 24, 2023 08:28
@liamcervante liamcervante merged commit 5c01a6c into v1.4 Apr 24, 2023
@liamcervante liamcervante deleted the backport/liamcervante/sensitive_and_unknown/two/routinely-prepared-goblin branch April 24, 2023 08:53
@github-actions
Copy link
Copy Markdown
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link
Copy Markdown
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant