Merged
Conversation
jar-b
approved these changes
Aug 23, 2023
Member
jar-b
left a comment
jar-b
left a comment
There was a problem hiding this comment.
LGTM 🎉
% TF_ACC=1 go test -count=1 ./internal/backend/remote-state/s3/...
ok github.com/hashicorp/terraform/internal/backend/remote-state/s3 177.845s
Contributor
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
| var s3Config aws.Config | ||
| if v, ok := stringAttrDefaultEnvVarOk(obj, "endpoint", "AWS_ENDPOINT_URL_S3", "AWS_S3_ENDPOINT"); ok { | ||
| if v, ok := retrieveArgument(&diags, | ||
| newAttributeRetriever(obj, cty.GetAttrPath("endpoints").GetAttr("s3")), |
There was a problem hiding this comment.
are you sure it's working? When I to change from the deprecated endpoint to endpoints { s3 = ... } it's ignoring the value...
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the arguments for overriding AWS API endpoints into the argument
endpoints.Deprecates the arguments
dynamodb_endpoint,iam_endpoint,endpoint(S3), andsts_endpoint.Fixes #30492
Target Release
1.6.0
Draft CHANGELOG entry
UPGRADE NOTES
endpoints. This deprecates the argumentsdynamodb_endpoint,iam_endpoint,endpoint(S3), andsts_endpoint