Skip to content

Process only relevant variables in the testing framework #34072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liamcervante merged 1 commit into from
Oct 16, 2023
+205 −338
Merged

Process only relevant variables in the testing framework #34072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions internal/backend/local/backend_local.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import (
"sort"
"strings"

"github.com/hashicorp/hcl/v2"
"github.com/zclconf/go-cty/cty"

"github.com/hashicorp/terraform/internal/backend"
Expand Down Expand Up @@ -506,22 +505,3 @@ func (v unparsedUnknownVariableValue) ParseVariableValue(mode configs.VariablePa
SourceType: terraform.ValueFromInput,
}, nil
}

type unparsedTestVariableValue struct {
expr hcl.Expression
ctx *hcl.EvalContext
}

func (v unparsedTestVariableValue) ParseVariableValue(mode configs.VariableParsingMode) (*terraform.InputValue, tfdiags.Diagnostics) {
var diags tfdiags.Diagnostics
val, hclDiags := v.expr.Value(v.ctx) // nil because no function calls or variable references are allowed here
diags = diags.Append(hclDiags)

rng := tfdiags.SourceRangeFromHCL(v.expr.Range())

return &terraform.InputValue{
Value: val,
SourceType: terraform.ValueFromConfig, // Test variables always come from config.
SourceRange: rng,
}, diags
}
Loading