Skip to content

Backport of update hcl v2.19.1 into v1.6#34111

Merged
jbardin merged 3 commits intov1.6from
backport/jbardin/update-hcl/secondly-fair-scorpion
Oct 18, 2023
Merged

Backport of update hcl v2.19.1 into v1.6#34111
jbardin merged 3 commits intov1.6from
backport/jbardin/update-hcl/secondly-fair-scorpion

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Oct 18, 2023

Backport

This PR is auto-generated from #34108 to be assessed for backporting due to the inclusion of the label 1.6-backport.

The below text is copied from the body of the original PR.


Update hcl to v2.19.1, which fixes an issue where the decoder can return null or unknown values which still contain optional attribute type constraints.

Remove invalid configschema tests. Schema attributes must have a type to be valid. These would have panicked anyway when used in other cases, but were passing within the limited test case. The update to hcl makes these panic earlier, so add our own panics to prevent invalid attribute schemas entirely.

We can be fairly certain these panics didn't affect actual functionality outside of the synthetic tests, because hcldec was returning an invalid cty.NilVal with no error, which itself would have panicked later if used.


Overview of commits

@ghost ghost force-pushed the backport/jbardin/update-hcl/secondly-fair-scorpion branch from 5e2694e to 0eb2069 Compare October 18, 2023 17:00
@ghost ghost assigned jbardin Oct 18, 2023
@ghost ghost force-pushed the backport/jbardin/update-hcl/secondly-fair-scorpion branch from 592b4ce to 08c74ee Compare October 18, 2023 17:00
@ghost ghost requested a review from jbardin October 18, 2023 17:00
@jbardin jbardin merged commit 0b87bd3 into v1.6 Oct 18, 2023
@jbardin jbardin deleted the backport/jbardin/update-hcl/secondly-fair-scorpion branch October 18, 2023 17:14
@github-actions
Copy link
Copy Markdown
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 7, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant