testing framework: allow providers to reference run blocks#34118
Merged
liamcervante merged 2 commits intomainfrom Nov 8, 2023
Merged
testing framework: allow providers to reference run blocks#34118liamcervante merged 2 commits intomainfrom
liamcervante merged 2 commits intomainfrom
Conversation
jbardin
approved these changes
Nov 7, 2023
Contributor
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows provider configurations to reference run blocks inside testing files.
To make this possible, I've introduced a field in the
TestSuiteRunnerthat tracks the providers required for each configuration that a test suite might require. This is so that we can now selectively hand providers over to each run block as required, instead of the previous approach which simply copied all the provider configurations across for every run block.I also fixed a bug in the provider configuration logic that meant it wasn't properly raising diagnostics and giving bad error messages for problems within the provider configurations.
Fixes #34100
Fixes #34007
Target Release
1.7.0
Draft CHANGELOG entry
ENHANCEMENTS
terraform test: Allow referencing run blocks from provider configurations in test files.