backend/s3: Adds parameter skip_s3_checksum to skip checksum on upload#34127
Merged
backend/s3: Adds parameter skip_s3_checksum to skip checksum on upload#34127
skip_s3_checksum to skip checksum on upload#34127Conversation
jar-b
approved these changes
Oct 24, 2023
Member
jar-b
left a comment
There was a problem hiding this comment.
LGTM 🎉
% TF_ACC=1 go test -count=1 ./internal/backend/remote-state/s3/...
ok github.com/hashicorp/terraform/internal/backend/remote-state/s3 144.245s
Contributor
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
@gdavison Hi! When will terraform 1.6.3 release be published? |
Contributor
|
@kamenskiyyyy It is variable, but in the normal state of events it would be available in the middle of next week. This can change depending on variety of factors. |
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some "S3-compatible" APIs do not support the header
x-amz-sdk-checksum-algorithm. In the S3 API, a checksum is recommended and is required when Object Lock is enabled.Allow users to disable the header.
Fixes #34099
Fixes #34086
Relates #34053 (comment)
Target Release
1.6.3
Draft CHANGELOG entry
ENHANCEMENTS