Skip to content

disconnect remote-exec immediately#34814

Merged
jbardin merged 1 commit intomainfrom
jbardin/disconnect-ssh-faster
Mar 11, 2024
Merged

disconnect remote-exec immediately#34814
jbardin merged 1 commit intomainfrom
jbardin/disconnect-ssh-faster

Conversation

@jbardin
Copy link
Copy Markdown
Member

@jbardin jbardin commented Mar 11, 2024

The remote-exec provisioner was not disconnecting immediately after provisioning. The remote exec context was tied to the lifetime of the provisioner, but the provisioner node used to not live long after the remote execution had completed so it was not noticed. Some more recent refactoring extends the lifetime of the node, and causes the provisioner connections to hang around longer when they're not needed.

Ensure we disconnect immediately after the remote execution is complete.

Fixes #34137

@jbardin jbardin requested a review from a team March 11, 2024 16:19
@apparentlymart
Copy link
Copy Markdown
Contributor

apparentlymart commented Mar 11, 2024

(The Code Consistency Checks failure here was caused by my merge of #34806 which has made the Consul backend no longer depend on legacy/helper/schema. I expect that if you rebase this branch and run make syncdeps then that error should go away. If not, please let me know and I'll try to debug further!)

@jbardin jbardin force-pushed the jbardin/disconnect-ssh-faster branch from f9c95ea to c8b310a Compare March 11, 2024 16:54
The remote-exec provisioner was not disconnecting immediately after
provisioning. The remote exec context was tired to the lifetime of the
provisioner, but the provisioner node used to not live long after the
remote execution had completed so it was not noticed. Some more recent
refactoring extends the lifetime of the node, and causes the provisioner
connections to hang around longer when they're not needed.

Ensure we disconnect immediately after the remote execution is complete.
@jbardin jbardin force-pushed the jbardin/disconnect-ssh-faster branch from c8b310a to 154f9ad Compare March 11, 2024 16:56
@jbardin jbardin merged commit 58dac51 into main Mar 11, 2024
@jbardin jbardin deleted the jbardin/disconnect-ssh-faster branch March 11, 2024 17:04
@github-actions
Copy link
Copy Markdown
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link
Copy Markdown
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SSH connections are kept open

2 participants