plan renderer: ensure JSON strings are completely JSON#34959
Merged
liamcervante merged 1 commit intomainfrom Apr 11, 2024
Merged
plan renderer: ensure JSON strings are completely JSON#34959liamcervante merged 1 commit intomainfrom
liamcervante merged 1 commit intomainfrom
Conversation
jbardin
approved these changes
Apr 8, 2024
Contributor
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't merge (or at least backport) this until after the release of 1.8.0 has been completed this week.
In #34702 we modified the JSON parsing of the plan renderer to support large (> 2^64) numbers. In doing so we changed the parsing to use the json.Decoder. The Decoder accepts partial JSON strings, so this means that a string that starts with a valid JSON object and then ends with a non-JSON piece of text is interpreted as valid JSON.
This PR updates the renderer so it checks the decoder has consumed the complete string before trusting that the returned object can be rendered as JSON.
In Martin's comments, he details how the
ctyjsonpackage supports this and the large number parsing by default. Unfortunately, we can't use thectyjsonpackage here as the renderer doesn't handlecty.Valueobjects instead just relying on the raw JSON objects that are available from thejsonplanpackage.Fixes #34954
Target Version
v1.8.1
Proposed CHANGELOG
BUG FIXES