go.mod: go get github.com/apparentlymart/go-versions@v1.0.2#35181
Merged
apparentlymart merged 1 commit intomainfrom May 24, 2024
Merged
go.mod: go get github.com/apparentlymart/go-versions@v1.0.2#35181apparentlymart merged 1 commit intomainfrom
apparentlymart merged 1 commit intomainfrom
Conversation
This includes a fix in the handling of conflicting constraints referring to prereleases, like "1.0.0-beta.1, !1.0.0-beta.1". Previously the library would incorrectly treat that as a positive match, rather than having the negative override the positive as happens in all other cases.
jbardin
approved these changes
May 23, 2024
Contributor
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes a fix in the handling of conflicting constraints referring to prereleases, like "1.0.0-beta.1, !1.0.0-beta.1".
Previously the library would incorrectly treat that as a positive match, rather than having the negative override the positive as happens in all other cases.
(More info in the upstream PR apparentlymart/go-versions#5 )
This fixes #33452 .
This library appears as a transitive dependency of the remote state backend and legacy modules just due to referring to a main module package that itself uses go-versions.
As far as I can tell, the backends and legacy modules don't actually exercise any of the functionality that would use this package and so I don't expect this change to affect the remote state backends at all. Therefore I'm not asking the backend maintainers to review/test this one.