import: fix crash when referencing the imported resource from the 'id' field#35420
Merged
liamcervante merged 1 commit intomainfrom Jul 3, 2024
Merged
import: fix crash when referencing the imported resource from the 'id' field#35420liamcervante merged 1 commit intomainfrom
liamcervante merged 1 commit intomainfrom
Conversation
DanielMSchmidt
approved these changes
Jul 3, 2024
kmoe
approved these changes
Jul 3, 2024
liamcervante
added
the
1.9-backport
Contributor
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR validates import
idattributes to ensure they do not reference to be imported resource.Fixes #35416
Target Release
1.9.2
Draft CHANGELOG entry
BUG FIXES
importblocks: Fix crash that occurs when incorrectly referencing thetoresource from theidattribute.