Fix missing validation for count and for-each meta-arguments#35432
Merged
liamcervante merged 1 commit intomainfrom Jul 10, 2024
Merged
Fix missing validation for count and for-each meta-arguments#35432liamcervante merged 1 commit intomainfrom
liamcervante merged 1 commit intomainfrom
Conversation
jbardin
approved these changes
Jul 9, 2024
Contributor
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash that occurs when self-referencing direct instances from the count and for_each meta arguments. The same behaviour was also happening within the
importblocks. These have been updated to share the same code path, and more extensive test cases have been added to cover the missing edge cases.This had been partially fixed previously in #35407, but some edge-cases had been missed allowing certain conditions (direct instance references) to still trigger the panic.
Fixes #35427
Target Release
1.9.2
Draft CHANGELOG entry
BUG FIXES
countandfor_eachmeta arguments.