config generation: stop editing the original schema when filtering#35484
Merged
liamcervante merged 2 commits intomainfrom Jul 23, 2024
Merged
config generation: stop editing the original schema when filtering#35484liamcervante merged 2 commits intomainfrom
liamcervante merged 2 commits intomainfrom
Conversation
liamcervante
added
the
1.9-backport
kmoe
approved these changes
Jul 22, 2024
Contributor
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
liamcervante
pushed a commit
that referenced
this pull request
Jul 23, 2024
…35484) * config generation: stop editing the original schema when filtering * copywrite headers
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the schema filtering functions so they don't side-effect edit the original schema with the changes made while filtering. This was causing strange behaviour when generating config, as the value that had already been imported to state started disagreeing with the schema after the config had been generated.
Fixes #35478
Target Release
1.9.3
Draft CHANGELOG entry
BUG FIXES