Merged
Conversation
jbardin
force-pushed
the
jbardin/update-hcl
branch
from
cdafe7e to
76b0d9f
Compare
liamcervante
previously approved these changes
Feb 4, 2025
jbardin
force-pushed
the
jbardin/update-hcl
branch
from
ffede32 to
f9de718
Compare
liamcervante
approved these changes
Feb 4, 2025
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update HCL to the latest commit to test new boolean operator logic, allowing for more accurate unknown value handling and logical short-circuiting: hashicorp/hcl#713
The overall evaluation of boolean expressions should now follow roughly the same logic as conditional expressions. This means that as long as the expression itself is valid, if one side of the expression can create a short-circuit path in the logic, the evaluation diagnostics from the inactive side can be dropped.
Closes #24128
Fixes #31078, which was closed but was incomplete.