Skip to content

temporarily disable updated Go Windows symlink behavior #36575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbardin merged 2 commits into from
Feb 25, 2025
+7 −0
Merged

temporarily disable updated Go Windows symlink behavior #36575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74da834
Temporally disable new windows symlink behavior
jbardin Feb 25, 2025
863ded5
add changelog
jbardin Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changes/v1.11/BUG FIXES-20250225-083056.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
kind: BUG FIXES
body: Temporarily revert updated Windows symlink handling until we can account for known existing configurations using non-symlink junctions.
time: 2025-02-25T08:30:56.226882-05:00
custom:
Issue: "36575"
2 changes: 2 additions & 0 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ module github.com/hashicorp/terraform

go 1.24.0

godebug winsymlink=0
Copy link
Copy Markdown
Member

@radeksimko radeksimko Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL there is godebug stanza allowed here, I always assumed it's environment variables only

Copy link
Copy Markdown
Member Author

@jbardin jbardin Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was new feature in go1.23 so you can build a module with GODEBUG options by default, which is perfect timing for this particular go1.23 problem ;)


require (
github.com/Netflix/go-expect v0.0.0-20220104043353-73e0943537d2
github.com/ProtonMail/go-crypto v1.0.0
Expand Down