Skip to content

Backport of Filter ephemeral marks from planned value into v1.11#36631

Merged
jbardin merged 4 commits intov1.11from
backport/jbardin/filter-ephemeral-marks/secondly-social-mite
Mar 4, 2025
Merged

Backport of Filter ephemeral marks from planned value into v1.11#36631
jbardin merged 4 commits intov1.11from
backport/jbardin/filter-ephemeral-marks/secondly-social-mite

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot commented Mar 4, 2025

Backport

This PR is auto-generated from #36619 to be assessed for backporting due to the inclusion of the label 1.11-backport.

The below text is copied from the body of the original PR.


The filtering of ephemeral marks for the planned value was incorrectly using PathsWithMark, which only reports paths containing a specific mark or not, and can't account for multiple marks on a particular path. Create a marks.RemoveAll function which allows for correct filtering.

Fixes #36603

Target Release

v1.11

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

Overview of commits

@github-actions github-actions bot force-pushed the backport/jbardin/filter-ephemeral-marks/secondly-social-mite branch from 25eb9cd to a559b8f Compare March 4, 2025 12:55
@github-actions github-actions bot requested a review from jbardin March 4, 2025 12:55
@jbardin jbardin marked this pull request as ready for review March 4, 2025 12:58
@jbardin jbardin requested a review from a team as a code owner March 4, 2025 12:58
@jbardin jbardin merged commit e91e2bc into v1.11 Mar 4, 2025
7 checks passed
@jbardin jbardin deleted the backport/jbardin/filter-ephemeral-marks/secondly-social-mite branch March 4, 2025 13:11
@github-actions
Copy link
Copy Markdown
Contributor Author

github-actions bot commented Apr 4, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant