Conversation
2 tasks
… *unnecessary* management plane API call (#36623) * backend/azure: Infer `subscription_id` from Azure CLI if not specified * Avoid management plane call if not necessary There are four auth scenarios of the blob/container: 1. User specifies the SAS token 2. User specifies the shared access key 3. User specified to use AAD auth (and credential provided) 4. None of the above, management plane API call needed to list the shared access key and use it to auth For 1, 2 and 3, the management plane API can be skipped in most of the cases, except the target storage account is using private DNS zone. The blob/container data plane client requires the user to specify the base URI, which is not deterministic if the storage account opt in the private DNS zone. In this case, an additional management plane `GET` is required against the storage account, to retrieve the blob endpoint. While if private DNS zone is not used, the base URI can be composed in a fixed pattern, with the storage account name and container&blob name. Hence no management plane API call is needed. The user is expected to use the `subscription_id` and `resource_group_name` to indicate the above intent: Only if both are specified, the additional `GET` call will be invoked to get the accurate blob endpoint. (NOTE: the `subscription_id` can be inferred from the Azure CLI if unspecified) * No need for AAD auth if shared key or sas is specified * update * Add test * update comments * changelog
dbanck
force-pushed
the
backport/azure-backend-freely-bream
branch
from
a2368d3 to
fc1a36c
Compare
2 tasks
radeksimko
approved these changes
Mar 12, 2025
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a manual backport of #36623, since the automatic one failed (in #36676)
Target Release
1.11.2
CHANGELOG entry