Add warning when a cloud block is present in a child module#37180
Merged
SarahFrench merged 2 commits intomainfrom May 29, 2025
Merged
Add warning when a cloud block is present in a child module#37180SarahFrench merged 2 commits intomainfrom
cloud block is present in a child module#37180SarahFrench merged 2 commits intomainfrom
Conversation
radeksimko
approved these changes
May 29, 2025
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently users only see warnings about ignored
backendblocks in child modules, and there isn't an equivalent warning aboutcloudblocks. This PR (#29826) introduced thetestdata/nested-cloud-warningtesting fixtures for this, but that PR doesn't appear to include a test that uses them.This PR adds the missing warning, and adds a new test asserting the warning is present.
Target Release
N/A
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry