Skip to content

Update stacks plugin binary download to accommodate Zip contents in CRT style release #37211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Maed223 merged 2 commits into from
Jun 5, 2025
+2 −2
Merged

Update stacks plugin binary download to accommodate Zip contents in CRT style release #37211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e16c5f6
Updating the plugin binary manager to accomodate CRT style release zi…
Maed223 Jun 4, 2025
9e7c094
Merge branch 'main' into update-stacks-plugin-binary-download-to-acco…
Maed223 Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/pluginshared/binary.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ func (v BinaryManager) resolveRelease() (*Binary, error) {

// Unarchive
unzip := getter.ZipDecompressor{
FilesLimit: 1,
FilesLimit: 3, // plugin binary, .version file, and LICENSE.txt
FileSizeLimit: 500 * MB,
}
targetPath := v.binaryLocation()
Expand Down
2 changes: 1 addition & 1 deletion internal/pluginshared/stacksbinary.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ func NewStacksBinaryManager(ctx context.Context, stacksPluginDataDir, overridePa
overridePath: overridePath,
host: svchost.Hostname(serviceURL.Host),
client: client,
binaryName: "terraform-stacksplugin",
binaryName: "tfstacks",
pluginName: "stacksplugin",
goos: goos,
arch: arch,
Expand Down