Backport of test: don't panic when resolving references that haven't been evaluated into v1.13#37488
Merged
liamcervante merged 1 commit intov1.13from Aug 26, 2025
Conversation
3a5fc9b to
df04266
Compare
liamcervante
approved these changes
Aug 26, 2025
Contributor
Author
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #37484 to be assessed for backporting due to the inclusion of the label 1.13-backport.
🚨
The person who merged in the original PR is:
@liamcervante
This person should resolve the merge-conflict(s) by either:
The below text is copied from the body of the original PR.
There's a bit of an inconsistency in the way we handle references to objects that haven't been resolved. Resource and local references result in panics, the other references return dynamic values. This PR updates resources and locals so they behave in the same way as other references.
Note, that references to non-existent resources / locals still results in an error as this is checked separately. This isn't normally an issue in regular Terraform as you would have graph cycles if references were circular during regular execution. But, it is possible to assert values against incomplete plans in both
terraform testandterraform consoleand this is where you would see panics. Users can try to check values that weren't included in the plan because of an error or partial targeting, and this would result in panics. After this PR, we'd see unknown values returned for these references which matches the behaviour of modules / outputs / inputs.Fixes #37409
Target Release
1.13.1
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry
Overview of commits
2cfa404
a96a93c