actions: connect invoke flag with TFC#37544
Merged
liamcervante merged 2 commits intomainfrom Oct 8, 2025
Merged
Conversation
liamcervante
added
the
no-changelog-needed
3 tasks
liamcervante
force-pushed
the
liamcervante/cloud/invoke
branch
from
2b1233e to
5a31988
Compare
liamcervante
added
the
1.14-backport
ctrombley
reviewed
Oct 8, 2025
Comment on lines
+1643
to
+1647
| func (m *MockStateVersions) UploadSanitizedState(ctx context.Context, sanitizedStateUploadURL *string, sanitizedState []byte) error { | ||
| //TODO implement me | ||
| panic("implement me") | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Is this intended for this PR? I don't see it used elsewhere.
Contributor
Author
There was a problem hiding this comment.
it's just required because the underlying interface in go-tfe has changed - nothing uses it but I need to implement the function otherwise the tests don't compile.
ctrombley
previously approved these changes
Oct 8, 2025
Contributor
ctrombley
left a comment
ctrombley
left a comment
There was a problem hiding this comment.
LGTM, I left one small comment but not a blocker.
liamcervante
force-pushed
the
liamcervante/cloud/invoke
branch
from
51bf6f0 to
802df5e
Compare
ctrombley
approved these changes
Oct 8, 2025
DanielMSchmidt
approved these changes
Oct 8, 2025
3 tasks
liamcervante
pushed a commit
that referenced
this pull request
Oct 8, 2025
* actions: connect invoke flag with TFC * use latest go-tfe
liamcervante
pushed a commit
that referenced
this pull request
Oct 8, 2025
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connect the
-invokeflag up with thecloudbackend. The changes to go-tfe required for this change are still in draft, so this PR is just an example of how to do this once the necessary changes have been made to go-tfe.Target Release
1.14.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry