Make the JSON view for init commands use defaults from the hclog package#37840
Merged
SarahFrench merged 4 commits intomainfrom Nov 24, 2025
Merged
Make the JSON view for init commands use defaults from the hclog package#37840SarahFrench merged 4 commits intomainfrom
init commands use defaults from the hclog package#37840SarahFrench merged 4 commits intomainfrom
Conversation
ed34b97 to
113c455
Compare
3 tasks
519dfbb to
27e0fd6
Compare
mildwonkey
approved these changes
Nov 24, 2025
Contributor
mildwonkey
left a comment
There was a problem hiding this comment.
👍🏻 really nice investigative / proof-of-non-breakage work associated with this!
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #37818
The logs from
initinclude timestamps in formattime.RFC3339while other JSON logs usehclog.TimeFormatformat.This discrepancy is due to the logging implementation in #34886 avoiding hclog and instead printing a JSON string to the view's streams. If hclog was used directly then the calling code would not need to set a value for the timestamp and influence its format.
We can't get context from participants in the original PR to know why printing a JSON string was chosen and what limitations that might have been attempting to overcome. This PR assumes that there weren't any limitations and it was just unfamiliarity with hclog, which may or may not be true.
Regardless of why logging was implemented like that, making a change in the timestamp format may affect any systems consuming the logs, and at a minimum would require:Checking that there's no breaking change in HCP Terraform.Checking for required updates to terraform-exec and terraform-json.These concerns have been addressed, see #37818 (comment)
Target Release
1.15.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry