Skip to content

test: Add and update some init command tests, linting and code comment changes#38056

Merged
SarahFrench merged 5 commits intomainfrom
sarah/init-cmd-testing
Jan 20, 2026
Merged

test: Add and update some init command tests, linting and code comment changes#38056
SarahFrench merged 5 commits intomainfrom
sarah/init-cmd-testing

Conversation

@SarahFrench
Copy link
Copy Markdown
Member

@SarahFrench SarahFrench commented Jan 13, 2026

This PR:

  • Adds an explicit test for use of -backend=false - TestInit_backend_initFromState. Previously this was only tested indirectly when testing the get providers feature.
    • This meant also renaming the test TestInit_backend to TestInit_backend_initFromConfig
  • Updates TestInit_multipleArgs to be a bit more explicit, and add context about what the test is for
  • Addressing inaccurate // Create a temporary working directory that is empty code comments that have proliferated by copy and paste
  • Linting stuff

Target Release

N/A

Rollback Plan

  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@SarahFrench SarahFrench force-pushed the sarah/init-cmd-testing branch from 3394281 to de11a68 Compare January 14, 2026 09:54
@SarahFrench SarahFrench added the no-changelog-needed Add this to your PR if the change does not require a changelog entry label Jan 14, 2026
@SarahFrench SarahFrench force-pushed the sarah/init-cmd-testing branch from 3394281 to de11a68 Compare January 14, 2026 09:56
@SarahFrench SarahFrench marked this pull request as ready for review January 14, 2026 10:11
@SarahFrench SarahFrench requested a review from a team as a code owner January 14, 2026 10:11
@SarahFrench SarahFrench merged commit fa620ad into main Jan 20, 2026
7 checks passed
@SarahFrench SarahFrench deleted the sarah/init-cmd-testing branch January 20, 2026 09:14
@github-actions
Copy link
Copy Markdown
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog-needed Add this to your PR if the change does not require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants