Conversation
Contributor
Author
Changelog WarningCurrently this PR would target a v1.15 release. Please add a changelog entry for in the .changes/v1.15 folder, or discuss which release you'd like to target with your reviewer. If you believe this change does not need a changelog entry, please add the 'no-changelog-needed' label. |
831194c to
6db9b6d
Compare
Contributor
Author
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #38071 to be assessed for backporting due to the inclusion of the label 1.14-backport.
🚨
The person who merged in the original PR is:
@aaabdelgany
This person should resolve the merge-conflict(s) by either:
The below text is copied from the body of the original PR.
The source bundle parsing process relies on the output of sourcebundle#Bundle.LocalPathForSource to determine the source directory for a source bundle. This function can confusingly return both absolute and relative paths. It was previously assumed that this output would always be absolute -which led us to run into errors when trying to relativize an already relative path.
This PR corrects that by converting absolute paths to relative ones or leaving in the source directory as is if it's already relative.
Fixes #
#38025
Target Release
1.15.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
N/A
CHANGELOG entry
Overview of commits
8a63ac9
1ed50c2
4fe0dd4
0f25b99
9a9938d
587fc8e