Simplify secret request UX

[jasonodonnell]

Overview

This makes a backwards incompatible change to the UX for requesting secrets from Vault. Changing the UX in a required way is not something I take lightly but I believe now is the best time to get this right.

This change makes requesting secrets more explicit by requiring the full path of the secret, rather than configuring extra parameters such as path and kv-version. By being more explicit with the secret path, mixing secret engines is possible and there are less parameters to configure.

Additionally I added a bit of logic to unpack responses from Vault data smarter (instead of relying on parameters to change the selector logic).

New UX:

- name: Import Secrets
   uses: hashicorp/vault-action
   with:
     url: https://vault.mycompany.com:8200
     token: ${{ secrets.VaultToken }}
     secrets: |
         aws/ci/app accessKey | AWS_ACCESS_KEY_ID ;
         aws/ci/app secretKey | AWS_SECRET_ACCESS_KEY ;
         my-secret/data/ci npm_token

Old UX:

- name: Import Secrets
   uses: hashicorp/vault-action
   with:
     url: https://vault.mycompany.com:8200
     token: ${{ secrets.VaultToken }}
     path: "aws"
     kv-version: 1
     secrets: |
         ci/app accessKey | AWS_ACCESS_KEY_ID ;
         ci/app secretKey | AWS_SECRET_ACCESS_KEY ;
         /my-secret/data/ci npm_token

Testing

To execute the unit tests, run the following commands:

$ docker-compose up -d vault
$ npm run build
$ npm install
$ ./node_modules/jest/bin/jest.js -c integrationTests/basic/jest.config.js

The e2e tests are currently done via a GitHub workflow and cannot be run locally. These will be moved to local integration tests and executed by the workflow in the future.

[RichiCoder1]

I was wondering what you meant by simplifying the UX. Looks great, this is exactly what I wanted to do in a breaking change at some point. So much fragile logic in the short-form K/V logic.

[Valarissa]

Less magic = more better. Tests pass and changes look good.

[vitek-urbanec]

The breaking change reference here from v2.x release is a bit misleading, because the secret scopes are missing the secret/data prefix in the "new UX" example, like it is described in the master readme. Took me a bit to figure that out.