Add ability to export Vault Token#127
Conversation
|
|
jasonodonnell
left a comment
jasonodonnell
left a comment
There was a problem hiding this comment.
Thanks for the contribution! A number of tests broke (you can ignore e2e-tls, we have a bug where community members can't access our GH secrets set on the repo). From what I gathered through the action logs, it appears exportToken is exporting the token even though it defaults to false.
I wonder if you'll need better equality checking similar to tls-skip-verify: https://github.com/hashicorp/vault-action/blob/master/src/action.js#L31-L34
To run the basic test you can run the following in the root of the project:
npm run test.
Additionally, if there is a bug and it's fixed, we'll want test coverage on this to ensure the functionality of this feature.
|
Your right, my condition was wrong. |
|
Hi @fean5959a, thanks for fixing that! We'll also need additional test coverage to ensure this configurable works. Do you think you can add it? I think the basic test ( |
|
Yes I can, and I encountered some bug when secret has a form of my-secret-key (with dash) ... |
Fix key with dash
|
Do you think my PR can be merged ? accepted or are you checking it ? |
There was a problem hiding this comment.
@fean5959a Everything looks good and I'd like to merge this, but have one more request. Can you remove the changes to dist/index.js? GitHub Actions uses this file when someone invokes the action and we've found that a lot of folks using the action point to master instead of tagged releases. Due to this we're cautious about updating this file and do it when we officially release Vault Action (2nd Tuesday of each month) to ensure we properly test all merged PRs.
4 participants
Usefull when run terraform, packer etc ... in a workflow and want to use directly Vault token.