Implement JWT auth#188
Merged
Merged
Conversation
|
|
Closed
Contributor
Author
|
@jasonodonnell gentle ping 🙂 |
Contributor
|
Thanks for the ping @grascm, we will take a look at this ASAP! 👍 |
jasonodonnell
self-requested a review
March 15, 2021 19:44
Contributor
Author
|
@jasonodonnell another one gentle ping 🙂 |
jasonodonnell
suggested changes
Apr 22, 2021
jasonodonnell
left a comment
jasonodonnell
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the ping, I'm taking a look now! In general this looks good but I need to test some stuff.
Small ask: can you remove the dist/index.js change? We prefer to do this build on our end only when we're ready to release new versions.
Merged
|
Is there a good setup document that walks through ground-up configuration of JWT auth? I too am familiar with the GitLab implementation and am looking for how I can implement GitHub actions the the same type of auth. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.