Set output for the error message#446
Merged
maxcoulombe merged 3 commits intoMay 19, 2023
Merged
Conversation
In the event vault-action throws an error, the error message is sent to the workflow log when with core.setFailed, but that output is not accessible to other steps in the workflow. This change sets an output for the error message, called errorMessage, than can be read by other steps within the workflow and parsed.
wagnerm
marked this pull request as ready for review
April 14, 2023 17:39
maithyton
self-requested a review
May 5, 2023 17:07
maithyton
requested changes
May 5, 2023
Collaborator
There was a problem hiding this comment.
Hey @wagnerm, thanks for adding this good enhancement! Could we have it documented next to Features section under Unreleased in CHANGELOG.md?
Improvements:
* Set an output `errorMessage` to vault-action's error message so that following steps in the workflow can read [GH-446](https://github.com/hashicorp/vault-action/pull/446)
* main: Add userpass auth and ldap auth support (hashicorp#440) chore(deps-dev): bump jest from 29.4.3 to 29.5.0 (hashicorp#438)
maxcoulombe
approved these changes
May 19, 2023
maxcoulombe
left a comment
maxcoulombe
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding this contribution and thinking about editing the unreleased changes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the event vault-action throws an error, the error message is sent to the workflow log when with
core.setFailed, but that output is not accessible to other steps in the workflow.This change sets an output for the error message, called errorMessage, than can be read by other steps within the workflow and parsed.