Add TLS and mTLS#97
Merged
Merged
Conversation
jasonodonnell
force-pushed
the
tls
branch
2 times, most recently
from
August 5, 2020 19:49
8fdfc0d to
f3483ab
Compare
jasonodonnell
marked this pull request as ready for review
August 5, 2020 20:36
tomhjp
approved these changes
Aug 6, 2020
tomhjp
left a comment
Contributor
There was a problem hiding this comment.
Nice 👍 LGTM, although my JavaScript knowledge is pretty shallow.
Valarissa
approved these changes
Aug 6, 2020
Valarissa
left a comment
There was a problem hiding this comment.
I enjoy how deliciously go-like this JS is, lol. LGTM.
Contributor
|
Whoop! Nice.
True to this action's history of being a mish-mash of language and pattern influences 😁 |
This was referenced Aug 7, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the action does not support TLS or mTLS. This adds new parameters to support these features:
caCertificateclientCertificateclientKeytlsSkipVerifyThis current implementation expects that the client key is not password protected. This could be added in the future if needed.
I made some other tweaks while I was in here:
docker-compose.yamlfor the various testsgotto 11.5.1. This is required for the custom TLS settings.All of these tests are run when a pull request is opened. See the checks below for the specific test outputs.