-
Notifications
You must be signed in to change notification settings - Fork 124
Add Recursive Secret Discovery, Combining Secrets, and Key Normalization #1040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
perestoronin
wants to merge
10
commits into
hashicorp:main
Choose a base branch
from
perestoronin:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add vaultRootPath
Add VaultRootPath logic
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
Add combineSecrets, normalizeEnvVars
Add logic combinedData, NormalizeEnvVars
Rename parameter to normalizeToScreamingCase
Add github.com/iancoleman/strcase v0.3.0
move new parameters to syncConfig
improve and clean logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Recursive Secret Discovery, Combining Secrets, and Key Normalization
Overview
This PR introduces:
SCREAMING_SNAKE_CASE
.These features are optional and backward-compatible.
Key Changes
1. CRD Updates
New fields added under
syncConfig
:vaultRootPath
(optional): Root path for recursive discovery.combineSecrets
(default:true
): Combine secrets into one.normalizeToScreamingCase
(default:true
): Normalize keys.Example:
Features
Recursive Secret Discovery
Performs a
LIST
request on the specifiedvaultRootPath
.Example:
Combine Secrets
Merges secrets into a single map if
combineSecrets = true
.Example:
Key Normalization
Normalizes keys to
SCREAMING_SNAKE_CASE
usingstrcase.ToScreamingSnake
.Example:
Usage Examples
Combined Secrets
Individual Secrets
Backward Compatibility
syncConfig
remain unaffected.Conclusion
This PR enhances VSO with recursive secret discovery, combining secrets, and key normalization while maintaining backward compatibility. Feedback is welcome!