-
Notifications
You must be signed in to change notification settings - Fork 124
Add CSI driver to threat model #1106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CSI driver to threat model #1106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far. I made some minor suggestions.
</ul> | ||
</td> | ||
</tr> | ||
</table> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would good to link out to the API reference docs, especially for the CSISecrets.spec
. We can probably add that later once they are fully published.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few minor suggestions. Looking good so far!
Co-authored-by: Ben Ash <[email protected]>
f8409d9
into
VAULT-31684/release-vso-csi
The new VSO CSI driver functionality shares many of the security concerns of the traditional way of running VSO, but introduces a new threat vector, so I detail it here in a separate section.
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.