Skip to content

Conversation

digivava
Copy link
Collaborator

@digivava digivava commented Sep 3, 2025

The new VSO CSI driver functionality shares many of the security concerns of the traditional way of running VSO, but introduces a new threat vector, so I detail it here in a separate section.

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.

  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.

  • If applicable, I've documented the impact of any changes to security controls.

    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@digivava digivava requested a review from a team as a code owner September 3, 2025 18:01
Copy link
Collaborator

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. I made some minor suggestions.

</ul>
</td>
</tr>
</table>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would good to link out to the API reference docs, especially for the CSISecrets.spec. We can probably add that later once they are fully published.

Copy link
Collaborator

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few minor suggestions. Looking good so far!

Co-authored-by: Ben Ash <[email protected]>
@mcollao-hc mcollao-hc self-requested a review September 3, 2025 21:25
@digivava digivava merged commit f8409d9 into VAULT-31684/release-vso-csi Sep 3, 2025
101 of 103 checks passed
@digivava digivava deleted the VAULT-37288/vso-csi-model branch September 3, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants