Skip to content

Conversation

jacob-faber
Copy link
Contributor

Fixes #658

@jacob-faber jacob-faber requested a review from a team as a code owner March 17, 2024 05:46
@hashicorp-cla
Copy link

hashicorp-cla commented Mar 17, 2024

CLA assistant check
All committers have signed the CLA.

@benashz
Copy link
Collaborator

benashz commented Mar 18, 2024

Thanks for the contribution @jacob-faber - I would be more in favour of making this change a bit simpler. We could just say that if there are any transformations defined for the destination then skip the hard coded data rendering.

@jacob-faber
Copy link
Contributor Author

@benashz, Do you think

if len(data["ca_chain"]) > 0 {
data["ca_chain"] = []byte(strings.Join(certResp.CAChain, "\n"))
}
should be skipped too?

@benashz benashz self-requested a review March 19, 2024 12:34
@benashz benashz added this to the v0.7.0 milestone May 7, 2024
Copy link
Collaborator

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@benashz benashz merged commit fca6e9e into hashicorp:main May 27, 2024
@jacob-faber jacob-faber deleted the bugfix/tls-overwritte-in-template branch May 28, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overwriting tls.crt and tls.key when using secret type kubernetes.io/tls for VaultPKISecret
3 participants