Ensure that spec.hmacSecretData's value is honoured #753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benashz
force-pushed
the
VAULT-27088/vss-fix-cannot-disable-hmacSecretData-on-first-apply
branch
from
325d198 to
b876541
Compare
benashz
changed the title
benashz
force-pushed
the
VAULT-27088/vss-fix-cannot-disable-hmacSecretData-on-first-apply
branch
from
b876541 to
d7280ba
Compare
Previously, upon the first application of a VaultStaticSecret instance that had spec.hmacSecretData explicitly set to false, the K8s API would replace that value with default as is defined in the CRD's schema. This fix makes HMACSecretData a pointer receiver, which make K8s do the right thing.
benashz
force-pushed
the
VAULT-27088/vss-fix-cannot-disable-hmacSecretData-on-first-apply
branch
from
d7280ba to
5f5de78
Compare
…tData-on-first-apply
|
Thanks! |
benashz
deleted the
VAULT-27088/vss-fix-cannot-disable-hmacSecretData-on-first-apply
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, upon the first application of a VaultStaticSecret instance that had spec.hmacSecretData explicitly set to false, the K8s API would replace that value with default as is defined in the CRD's schema. This fix makes HMACSecretData a pointer receiver, which make K8s do the right thing.