Skip to content

Helm: support setting VaultAuthGlobalRef on VaultAuth #851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 15, 2024
Merged

Helm: support setting VaultAuthGlobalRef on VaultAuth #851

merged 2 commits into from
Jul 15, 2024

Conversation

benashz
Copy link
Collaborator

@benashz benashz commented Jul 12, 2024 •
edited
Loading

Add support for configuring the default VaultAuth's .spec.vaultAuthGlobalRef from Helm values.

helm install ... \
        --set 'defaultAuthMethod.enabled=true' \
        --set 'defaultAuthMethod.vaultAuthGlobalRef.enabled=true' \
        --set 'defaultAuthMethod.vaultAuthGlobalRef.name=foo' \
        --set 'defaultAuthMethod.vaultAuthGlobalRef.namespace=baz' \

@benashz benashz requested a review from a team as a code owner July 12, 2024 21:12
@benashz benashz requested a review from tvoran July 12, 2024 21:12
@benashz benashz force-pushed the VAULT-28023/helm-add-support-for-vag branch from c5242b3 to 1d58fff Compare July 12, 2024 21:18
@benashz benashz force-pushed the VAULT-28023/helm-add-support-for-vag branch from 1d58fff to 669c5e7 Compare July 12, 2024 21:24
@benashz benashz added this to the v0.8.0 milestone Jul 15, 2024
thyton
thyton approved these changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@thyton thyton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benashz benashz merged commit 82802d3 into main Jul 15, 2024
@benashz benashz deleted the VAULT-28023/helm-add-support-for-vag branch July 15, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thyton thyton thyton approved these changes

@tvoran tvoran Awaiting requested review from tvoran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@benashz @thyton