-
Notifications
You must be signed in to change notification settings - Fork 4.4k
VAULT-35602: Adding Enos OpenLDAP test #30801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CI Results: |
Build Results: |
b9108e4
to
10d75cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we write to a non-existent fake LDAP server. It might be worth updating this to point to the one Enos has spun up.
114972c
to
01fd627
Compare
98ad82f
to
0c954ed
Compare
9da70d6
to
d21c7d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Let's just do that rename and merge this.
d21c7d0
to
49ffc81
Compare
Description
VAULT-35602: Adding Enos OpenLDAP test
TODO only if you're a HashiCorp employee
backport/
label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x
, but older release branches will bebackport/ent/x.x.x+ent
.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.