Skip to content

VAULT-35602: Adding Enos OpenLDAP test #30801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 23, 2025
Merged

VAULT-35602: Adding Enos OpenLDAP test #30801

merged 3 commits into from
Jul 23, 2025

Conversation

tvo0813
Copy link
Collaborator

@tvo0813 tvo0813 commented May 31, 2025

Description

VAULT-35602: Adding Enos OpenLDAP test

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@tvo0813 tvo0813 requested a review from a team as a code owner May 31, 2025 00:09
@tvo0813 tvo0813 force-pushed the enos/VAULT-35602 branch from 79ce381 to 2d4e10f Compare May 31, 2025 00:09
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 31, 2025
@tvo0813 tvo0813 added pr/no-changelog pr/no-milestone backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/ent/1.17.x+ent backport/ent/1.18.x+ent and removed hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed labels May 31, 2025
Copy link

github-actions bot commented May 31, 2025

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented May 31, 2025

Build Results:
All builds succeeded! ✅

@tvo0813 tvo0813 force-pushed the enos/VAULT-35602 branch from 2d4e10f to 9ac1184 Compare June 2, 2025 22:00
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jun 2, 2025
@tvo0813 tvo0813 force-pushed the enos/VAULT-35602 branch 5 times, most recently from b9108e4 to 10d75cb Compare June 4, 2025 00:31
Copy link
Contributor

@brewgator brewgator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we write to a non-existent fake LDAP server. It might be worth updating this to point to the one Enos has spun up.

@tvo0813 tvo0813 force-pushed the enos/VAULT-35602 branch 9 times, most recently from 114972c to 01fd627 Compare June 12, 2025 17:04
@tvo0813 tvo0813 force-pushed the enos/VAULT-35602 branch 13 times, most recently from 98ad82f to 0c954ed Compare July 22, 2025 16:14
@tvo0813 tvo0813 force-pushed the enos/VAULT-35602 branch 6 times, most recently from 9da70d6 to d21c7d0 Compare July 23, 2025 18:26
Copy link
Collaborator

@ryancragun ryancragun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's just do that rename and merge this.

@tvo0813 tvo0813 force-pushed the enos/VAULT-35602 branch from d21c7d0 to 49ffc81 Compare July 23, 2025 19:46
@tvo0813 tvo0813 merged commit 857e66b into main Jul 23, 2025
55 checks passed
@tvo0813 tvo0813 deleted the enos/VAULT-35602 branch July 23, 2025 20:11
@tvo0813 tvo0813 restored the enos/VAULT-35602 branch July 23, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants