Skip to content

Conversation

jaireddjawed
Copy link
Contributor

@jaireddjawed jaireddjawed commented Jun 8, 2025

Description

What does this PR do?

A recent update (PR here) to the Azure Auth Plugin requires that either bound_service_principal_ids or bound_group_ids be provided when creating an azure auth role in Vault. This PR updates the documentation for Vault 1.20 to accomodate this change.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@jaireddjawed jaireddjawed self-assigned this Jun 8, 2025
@jaireddjawed jaireddjawed requested review from a team as code owners June 8, 2025 19:34
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jun 8, 2025
@jaireddjawed jaireddjawed added this to the 1.20.0-rc milestone Jun 8, 2025
Copy link

github-actions bot commented Jun 8, 2025

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Jun 8, 2025

Build Results:
All builds succeeded! ✅

Copy link
Collaborator

@anwittin anwittin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating this

@fairclothjm
Copy link
Contributor

FYI, you can prefix your git branch with docs/ to skip most of the CI checks for documentation PRs.

@jaireddjawed jaireddjawed merged commit f8b8b2a into main Jun 9, 2025
43 of 47 checks passed
@jaireddjawed jaireddjawed deleted the VAULT-36152-azure-doc-update branch June 9, 2025 15:23
drivera258 pushed a commit that referenced this pull request Jun 11, 2025
Erfankam pushed a commit to Erfankam/vault that referenced this pull request Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants