Skip to content

Conversation

lursu
Copy link
Collaborator

@lursu lursu commented Jul 25, 2025

Description

What does this PR do?

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.

Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@lursu lursu requested review from ldilalla-HC and tomcf-hcp July 25, 2025 16:36
@lursu lursu requested a review from a team as a code owner July 25, 2025 16:36
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 25, 2025
Copy link

CI Results:
All Go tests succeeded! ✅

Copy link

Build Results:
All builds succeeded! ✅

miagilepner
miagilepner previously approved these changes Jul 25, 2025
tomcf-hcp
tomcf-hcp previously approved these changes Jul 25, 2025
@sgmiller sgmiller dismissed stale reviews from tomcf-hcp and miagilepner via a2c075e July 25, 2025 19:02
Copy link

vercel bot commented Jul 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vault-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2025 7:03pm

@sgmiller
Copy link
Collaborator

Added some PQC changelog edits to correct omissions and clarify where those algos live.

@lursu lursu requested review from miagilepner and tomcf-hcp July 25, 2025 19:17
@lursu lursu merged commit a47862e into main Jul 25, 2025
34 checks passed
@lursu lursu deleted the VAULT-38326/updated_changelog_for_release branch July 25, 2025 19:24
Erfankam pushed a commit to Erfankam/vault that referenced this pull request Sep 1, 2025
* added changelog records for minor release

* PQC algorithm changelog edits

---------

Co-authored-by: lursu <[email protected]>
Co-authored-by: Scott G. Miller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants