Skip to content

Conversation

emoncuso
Copy link
Contributor

Description

Replaces the internal tooltip on "delete transformation" with an HDS tooltip

References

jira: https://hashicorp.atlassian.net/browse/VAULT-38496

before:
Screenshot 2025-07-30 at 2 56 20 PM

after:
Screenshot 2025-07-30 at 2 54 47 PM

Testing instructions

Buckle up!

  • fire up a vault enterprise cluster
  • secrets engines -> enable -> transform -> create
  • create a transform
    • none of the details matter here, just remember the name
  • create a role
    • give it any name
    • assign the transformation above to this role
  • go back to your transformation
    • hover over delete
  • See the new and definitely different Hds Tooltip

Enterprise tests

✅ - ent tests pass

Screenshot 2025-07-30 at 2 27 36 PM

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.

Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@emoncuso emoncuso added this to the 1.20.2 milestone Jul 30, 2025
@emoncuso emoncuso requested a review from a team as a code owner July 30, 2025 22:23
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 30, 2025
Copy link

github-actions bot commented Jul 30, 2025

Build Results:
All builds succeeded! ✅

Copy link

github-actions bot commented Jul 30, 2025

CI Results:
All Go tests succeeded! ✅

zofskeez
zofskeez previously approved these changes Jul 31, 2025
@emoncuso emoncuso enabled auto-merge (squash) August 4, 2025 15:45
@emoncuso emoncuso force-pushed the vault-38496/replace-tooltip-in-transformation-edit-page branch from 2cc2cba to a312a1e Compare August 4, 2025 16:24
Copy link

vercel bot commented Aug 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vault-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 4, 2025 4:27pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants