UI Bug fix: Fix DR Secondary view #31478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
CI Results: |
Monkeychip
commented
Aug 12, 2025
There was a problem hiding this comment.
Just a clean up of this file. No tests were removed. And the only test added was to check that the analytics service is run on a dr primary (so the opposite test of what we check for on the dr secondary).
|
Build Results: |
emoncuso
approved these changes
Aug 13, 2025
1 task
Monkeychip
added a commit
that referenced
this pull request
Aug 14, 2025
* test coverage and the fix * not working * fix failing test * fix another test * changelog * the correct changelog number
1 task
Monkeychip
added a commit
that referenced
this pull request
Aug 14, 2025
* UI Bug fix: Fix DR Secondary view (#31478) * test coverage and the fix * not working * fix failing test * fix another test * changelog * the correct changelog number * selector backporting things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The DR secondary view failed to load after PR #30425. The error occurred because of the addition of the
asynckeyword to theafterModelhook. My best guess as to why this breaks the DR Secondary transition is thatasynccauses Ember to wait for any awaited promises before completing the route transition. For most routes, this is fine, but DR secondary is sensitive to timing, and the transition hangs/fails silently, breaking the transition.Note: The addition of
asyncon theafterModelhook does not cause a failure for Performance Secondaries.To repro:
d7bb0adfe0(the commit right before the Posthog PR), create a DR secondary, and navigate to the UI view. Then, check out the Posthog commit689ede2da5and follow the same steps. It works on the commit before, and fails on the regression commit.asyncbefore theafterModelhook on the cluster route, and the DR secondary will fail to transition. Removeasync, and it will transition. This shows that it's not thethis.analyticsservice check that's breaking the flow, it's theasynckeyword added to theafterModelhook.Failure:
After fix:
