Skip to content

Conversation

husunal
Copy link

@husunal husunal commented Aug 15, 2025

Description

Vault's certificate authentication method breaks when using x_forwarded_for_client_cert_header with load balancers that implement RFC 9440 Structured Headers specification, such as Google Cloud Application Load Balancer. In this format, the binary DER certificate is first Base64-encoded, then wrapped with leading and trailing colons e.g. :MIIC...==:. Without this change, Vault's Base64 decoder interprets the colons as part of the value, causing a decode error and preventing the forwarded certificate from being used with the TLS certificates auth method.

This MR fixes the problem by adding support for the RFC 9440 byte-sequence format without breaking backward compatibility.

Related MR: #17272

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.

Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@husunal husunal requested a review from a team as a code owner August 15, 2025 15:08
@husunal husunal requested a review from claudiac-m August 15, 2025 15:08
Copy link

vercel bot commented Aug 15, 2025

@husunal is attempting to deploy a commit to the HashiCorp Team on Vercel.

A member of the Team first needs to authorize it.

@husunal husunal force-pushed the feature/X-Forwarded-Client-Cert-rfc-9440 branch from e7a53e9 to b757b34 Compare August 15, 2025 15:25
@heatherezell heatherezell added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 15, 2025
Copy link
Contributor

@kitography kitography left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good - nice tests, nice comments, and a simple code change.

Are you able to write a changelog? That's a file changelog/31501.txt which describes the change:

```release-note:bugfix
http: describe your change here
```

@husunal husunal requested a review from kitography August 27, 2025 17:35
Copy link
Contributor

@kitography kitography left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks great!

@hc-github-team-secure-vault-core
Copy link
Collaborator

Copy workflow completed!

From To Error
hashicorp/vault#31501 hashicorp/vault-enterprise#9085

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants