Skip to content

Conversation

zofskeez
Copy link
Contributor

Description

These changes are associated with #31499 which updates the auth config forms in the UI to use the OpenAPI help responses to fully render the forms.

  • Identifier property was added to signal to the UI that it's the primary form field and should render first. This is typical in forms for items that have a path or name field which is used as the unique identifier.
  • Auth config display attr updates for things like name and group to align with the current statically defined UI forms.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.

Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@zofskeez zofskeez added this to the 1.21.0-rc1 milestone Aug 15, 2025
@zofskeez zofskeez requested a review from a team as a code owner August 15, 2025 16:40
@zofskeez zofskeez requested a review from hashievv August 15, 2025 16:40
@zofskeez zofskeez added the go Pull requests that update Go code label Aug 15, 2025
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 15, 2025
Copy link

github-actions bot commented Aug 15, 2025

CI Results:
All Go tests succeeded! ✅

Copy link

Build Results:
All builds succeeded! ✅

Copy link

vercel bot commented Aug 26, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
vault-ui Ready Ready Preview Comment Aug 27, 2025 9:03pm

Copy link
Contributor

@kpcraig kpcraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hc-github-team-secure-vault-core
Copy link
Collaborator

Copy workflow completed!

From To Error
hashicorp/vault#2749185759 hashicorp/vault-enterprise#2782280091

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants