Skip to content

Refactor to use reflect.TypeFor #31521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Refactor to use reflect.TypeFor #31521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion audit/hashstructure.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ type hashWalker struct {
// we can quickly compare in hashWalker.Struct. We create an empty/invalid
// time.Time{} so we don't need to incur any additional startup cost vs.
// Now() or Unix().
var hashTimeType = reflect.TypeOf(time.Time{})
var hashTimeType = reflect.TypeFor[time.Time]()

func (w *hashWalker) Enter(loc reflectwalk.Location) error {
w.loc = append(w.loc, loc)
Expand Down
4 changes: 2 additions & 2 deletions sdk/database/helper/connutil/sql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import (
"github.com/hashicorp/vault/sdk/helper/pluginutil"
"github.com/jackc/pgx/v4"
"github.com/jackc/pgx/v4/stdlib"
"github.com/jackc/pgx/v5"
"github.com/mitchellh/mapstructure"
)

Expand Down Expand Up @@ -83,8 +84,7 @@ type SQLConnectionProducer struct {

// This provides the field names for SQLConnectionProducer for field validation in the framework handler.
func SQLConnectionProducerFieldNames() map[string]any {
scp := &SQLConnectionProducer{}
rType := reflect.TypeOf(scp).Elem()
rType := reflect.TypeFor[SQLConnectionProducer]()

fieldNames := make(map[string]any, rType.NumField())
for i := range rType.NumField() {
Expand Down