-
Notifications
You must be signed in to change notification settings - Fork 193
Enhancing custom permissions #2152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,6 +42,7 @@ The following table summarizes the available organization-level permission categ | |
| | [Settings permissions](#settings-permissions) | Control access to governance and infrastructure tools. | | ||
| | [Private registry permissions](#private-registry-permissions) | Control access to the organization's private registry. | | ||
| | [Public registry permissions](#public-registry-permissions) | Control access to the public registry. | | ||
| | [Policy overrides](#policy-overrides) | Controls teams’ ability to override failed policy checks for policies with an enforcement level set to **Soft mandatory**. | | ||
|
|
||
| ## Project permissions | ||
|
|
||
|
|
@@ -214,7 +215,6 @@ The following permissions control access to governance and infrastructure tools. | |
| | Permission name | Description | | ||
| |-----------------|-------------| | ||
| | [Manage policies](#manage-policies) | Create, edit, read, list and delete Sentinel policies | | ||
| | [Manage policy overrides](#manage-policy-overrides) | Override soft-mandatory policy checks | | ||
| | [Manage run tasks](#manage-run-tasks) | Create, edit, and delete run tasks | | ||
| | [Manage version control settings](#manage-version-control-settings) | Manage VCS providers and SSH keys | | ||
| | [Manage agent pools](#manage-agent-pools) | Create, edit, and delete agent pools | | ||
|
|
@@ -229,12 +229,6 @@ This permission implicitly gives permission to read runs on all workspaces, whic | |
|
|
||
| Allows members to create, edit, and delete run tasks on the organization. | ||
|
|
||
| ### Manage policy overrides | ||
|
|
||
| Allows members to override soft-mandatory policy checks. | ||
|
|
||
| This permission implicitly gives permission to read runs on all workspaces, which is necessary to override policy checks. | ||
|
|
||
| ### Manage VCS settings | ||
|
|
||
| Allows members to manage the set of [VCS providers](/terraform/cloud-docs/vcs) and [SSH keys](/terraform/cloud-docs/vcs#ssh-keys) available within the organization. | ||
|
|
@@ -321,6 +315,34 @@ Allow members to publish and delete providers for the organization in the public | |
|
|
||
| <!-- END: TFC:only name:public-registry --> | ||
|
|
||
| ## Policy overrides | ||
|
|
||
| Policy override settings only apply to policies that have a **Soft mandatory** enforcement level. Refer to [Policy enforcement levels](/terraform/cloud-docs/policy-enforcement/manage-policy-sets#policy-enforcement-levels) for more information. | ||
|
|
||
| | Permission name | Description | | ||
| | --- | --- | | ||
| | [No policy overrides](#no-policy-overrides) | Teams can’t override failed **Soft mandatory** policy evaluations. | | ||
| | [Delegate policy overrides](#delegate-policy-overrides) | Allow project and workspace managers to grant override permissions for **Soft mandatory** policy evaluations. When this setting is enabled, the ability to override failed policy evaluations is disabled by default. Project and workspace managers must manually enable the **Allow policy overrides** setting in their projects and workspaces. | | ||
| | [Manage policy overrides](#manage-policy-overrides) | Team members can override failed **Soft mandatory** policy evaluations in all workspaces. | | ||
|
|
||
| ### No policy overrides | ||
|
|
||
| Teams can’t override failed **Soft mandatory** policy evaluations. | ||
|
|
||
| ### Delegate policy overrides | ||
|
|
||
| Allow project and workspace managers to grant override permissions for **Soft mandatory** policy evaluations. When this setting is enabled, overriding failed policy evaluations is disabled by default. Project and workspace managers must manually enable the **Allow policy overrides** setting in their projects and workspaces. | ||
|
|
||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These sections don't add much information beyond what's in the table already. What do you think about moving the "Refer to the projects and workspaces..." bit to the table, and removing these sections? (I'm ok if not)
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm just following the template we set up. The separate headings also give us direct links to each setting. |
||
| Refer to the [projects](/terraform/cloud-docs/users-teams-organizations/permissions/project#policy-overrides) and [workspaces](/terraform/cloud-docs/users-teams-organizations/permissions/workspace#policy-overrides) team permission references for more information. | ||
|
|
||
| ### Manage policy overrides | ||
|
|
||
| Team members can override failed **Soft mandatory** policy evaluations in all workspaces. | ||
trujillo-adam marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| This setting also gives teams read access to all workspaces in the organization. To prevent read access, enable the [**Delegate policy overrides**](#delegate-policy-overrides) setting instead. | ||
|
|
||
| Refer to the [projects](/terraform/cloud-docs/users-teams-organizations/permissions/project#policy-overrides) and [workspaces](/terraform/cloud-docs/users-teams-organizations/permissions/workspace#policy-overrides) team permission references for more information. | ||
|
|
||
| ## Organization owners | ||
|
|
||
| <!-- BEGIN: TFC:only name:hcp-eu --> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it also worth making it explicit that
Manage policy overridesgives read access to all workspaces in the organization, whileDelegate policy overridesdoes not? The read all workspaces behavior of the existing setting has been a big pain point for customers, so I'm wondering if we can highlight howDelegateis better.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this to the more detailed description linked from this table.