Add docs & api-docs for Azure Secrets Static Roles #908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vercel Previews Deployed
|
Broken Link CheckerNo broken links found! 🎉 |
schavis
requested changes
Sep 4, 2025
Comment on lines
+393
to
+395
| - `ttl` (`string: ""`) - Specifies the duration of time that the role's credentials are valid for. Accepts time | ||
| suffixed strings ("1h") or an integer number of seconds. Minimum of 1 year (8760h); if not set, or set to 0 | ||
| will use the default value of 2 years (17520h). |
There was a problem hiding this comment.
Suggested change
| - `ttl` (`string: ""`) - Specifies the duration of time that the role's credentials are valid for. Accepts time | |
| suffixed strings ("1h") or an integer number of seconds. Minimum of 1 year (8760h); if not set, or set to 0 | |
| will use the default value of 2 years (17520h). | |
| - `ttl` (`string: ""`) - Timespan of 1 year (`8760h`) or more during | |
| which the role credentials are valid. You can specify timespans | |
| as time suffixed strings (`"1h"`) or an integer number of | |
| seconds. Leave `ttl` unset or set to `0` to use the default value | |
| of 2 years (`17520h`). |
Style correction: write in active voice
There was a problem hiding this comment.
The first sentence doesn't seem clear to me? 1 year is just a lower bound of the parameter.
Co-authored-by: Sarah Chavis <[email protected]>
Co-authored-by: Sarah Chavis <[email protected]>
Co-authored-by: Sarah Chavis <[email protected]>
Co-authored-by: Sarah Chavis <[email protected]>
Co-authored-by: Sarah Chavis <[email protected]>
Co-authored-by: Sarah Chavis <[email protected]>
Co-authored-by: Sarah Chavis <[email protected]>
Co-authored-by: Sarah Chavis <[email protected]>
Co-authored-by: Sarah Chavis <[email protected]>
Co-authored-by: Sarah Chavis <[email protected]>
Co-authored-by: Sarah Chavis <[email protected]>
Co-authored-by: Sarah Chavis <[email protected]>
Co-authored-by: Sarah Chavis <[email protected]>
Co-authored-by: Sarah Chavis <[email protected]>
Co-authored-by: Sarah Chavis <[email protected]>
Co-authored-by: Sarah Chavis <[email protected]>
Co-authored-by: Sarah Chavis <[email protected]>
Co-authored-by: Sarah Chavis <[email protected]>
Co-authored-by: Sarah Chavis <[email protected]>
|
@schavis Thank you for the review. I had a question about the Also, not sure if the preview of docs work? I wanted to check if all the links are okay, but I don't see new additions on the "Preview" link listed above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds docs & api-docs for our new feature (Static Roles) in Azure Secrets Engine.